Suggest collecting into Vec<_>#105523
Merged
bors merged 6 commits intorust-lang:masterfrom Dec 14, 2022
Merged
Conversation
Collaborator
|
r? @davidtwco (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
Collaborator
|
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
Some changes occurred in need_type_info.rs cc @lcnr |
fmease
reviewed
Dec 10, 2022
This comment was marked as resolved.
This comment was marked as resolved.
estebank
force-pushed
the
suggest-collect-vec
branch
2 times, most recently
from
8701ab9 to
7b109bd
Compare
rustbot
added
the
A-translation
Collaborator
|
cc @davidtwco, @compiler-errors, @JohnTitor, @estebank, @TaKO8Ki |
compiler/rustc_infer/src/infer/error_reporting/need_type_info.rs
Outdated
Show resolved
Hide resolved
Remove previously existing fallback that tried to give a good turbofish suggestion, `need_type_info` is already good enough. Special case `::<Vec<_>` suggestion for `Iterator::collect`.
estebank
force-pushed
the
suggest-collect-vec
branch
from
c0dac34 to
165efab
Compare
Contributor
|
r? @compiler-errors i'll give this another look-over after lunch |
Contributor
compiler-errors
left a comment
compiler-errors
left a comment
There was a problem hiding this comment.
r=me with one nit addressed or not
compiler/rustc_infer/src/infer/error_reporting/need_type_info.rs
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@bors r=compiler-errors |
Collaborator
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 14, 2022
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#103644 (Add docs for question mark operator for Option) - rust-lang#105161 (Refine when invalid prefix case error arises) - rust-lang#105491 (Illegal sized bounds: only suggest mutability change if needed) - rust-lang#105502 (Suggest impl in the scenario of typo with fn) - rust-lang#105523 (Suggest `collect`ing into `Vec<_>`) - rust-lang#105595 (Suggest dereferencing receiver arguments properly) - rust-lang#105611 (fold instead of obliterating args) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 9, 2023
… r=compiler-errors Suggest defining const parameter when appropriate Helps a bit with rust-lang#91119. Following rust-lang#105523's lead, I use placeholder `/* Type */` instead of `_` in the suggestion. It should be easier for newcomers to parse. `@rustbot` label A-diagnostics r? diagnostics
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #105510.